Allow FID with torch.float64 #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1628 +/- ##
========================================
- Coverage 89% 41% -48%
========================================
Files 228 228
Lines 12363 12432 +69
========================================
- Hits 10945 5067 -5878
- Misses 1418 7365 +5947 |
Borda
approved these changes
Mar 17, 2023
justusschock
approved these changes
Mar 28, 2023
toshas
added a commit
to toshas/torch-fidelity
that referenced
this pull request
Apr 30, 2023
…lp numerical issues with inception feature extractor and its output variation due to the batch size. fix #43, related in torchmetrics: - Lightning-AI/torchmetrics#1620 - Lightning-AI/torchmetrics#1628 add explicit eval in the inception fe to help a case if someone copies just that file for metrics evaluation add explicit require_grad(False) to clip feature extractor add test cases to troubleshoot batch size dependence of metrics values
rustoneee
added a commit
to rustoneee/Pytorch-Generative-models-GAN-
that referenced
this pull request
Nov 6, 2023
…lp numerical issues with inception feature extractor and its output variation due to the batch size. fix #43, related in torchmetrics: - Lightning-AI/torchmetrics#1620 - Lightning-AI/torchmetrics#1628 add explicit eval in the inception fe to help a case if someone copies just that file for metrics evaluation add explicit require_grad(False) to clip feature extractor add test cases to troubleshoot batch size dependence of metrics values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1620
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃