-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.7 support #1640
Drop python 3.7 support #1640
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
========================================
- Coverage 89% 53% -36%
========================================
Files 228 228
Lines 12796 12794 -2
========================================
- Hits 11363 6770 -4593
- Misses 1433 6024 +4591 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Borda now the only problem that seems to remain is that the docker image used for the "old" build on azure still uses python 3.7 and not 3.8. |
What does this PR do?
Python 3.7 is blocking some other PRs:
#1636
#1570
and since the security support for 3.7 is soon ending, I think we can drop it.
Additionally, we are soon going to add python 3.11 support:
#1613
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃