Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7 support #1640

Merged
merged 38 commits into from
Apr 3, 2023
Merged

Drop python 3.7 support #1640

merged 38 commits into from
Apr 3, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Python 3.7 is blocking some other PRs:
#1636
#1570
and since the security support for 3.7 is soon ending, I think we can drop it.

Additionally, we are soon going to add python 3.11 support:
#1613

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1640 (0f2fcaf) into master (cb9540f) will decrease coverage by 36%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1640     +/-   ##
========================================
- Coverage      89%     53%    -36%     
========================================
  Files         228     228             
  Lines       12796   12794      -2     
========================================
- Hits        11363    6770   -4593     
- Misses       1433    6024   +4591     

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for #1613
resolving issue of mentioned PRs in their scope #1636 and #1570 :)

TODO:

  • bump sklearn version
  • remove skipif for sklearn

@mergify mergify bot removed the has conflicts label Mar 28, 2023
@SkafteNicki
Copy link
Member Author

@Borda now the only problem that seems to remain is that the docker image used for the "old" build on azure still uses python 3.7 and not 3.8.
There is a weird downgrade in the 1.9 image reported here:
pytorch/pytorch#60932
and here is a full list of python version for each image:
pytorch/pytorch#73714 (comment)

@Borda Borda enabled auto-merge (squash) April 3, 2023 15:38
@mergify mergify bot added the ready label Apr 3, 2023
@Borda Borda merged commit 845301b into master Apr 3, 2023
@Borda Borda deleted the drop_py37 branch April 3, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants