Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision-recall curve based computations for float target #1642

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1641
Some missing dtype casting.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 21, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 21, 2023
@SkafteNicki SkafteNicki requested a review from Borda as a code owner March 21, 2023 15:36
@SkafteNicki SkafteNicki changed the title Fix precision-recall based computations for float target Fix precision-recall curve based computations for float target Mar 21, 2023
@Borda Borda enabled auto-merge (squash) March 21, 2023 16:07
@mergify mergify bot requested a review from a team March 21, 2023 16:08
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1642 (e67148b) into master (685391d) will decrease coverage by 38%.
The diff coverage is 100%.

❗ Current head e67148b differs from pull request most recent head 9209c12. Consider uploading reports for the commit 9209c12 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1642     +/-   ##
========================================
- Coverage      89%     51%    -38%     
========================================
  Files         228     228             
  Lines       12363   12363             
========================================
- Hits        10945    6304   -4641     
- Misses       1418    6059   +4641     

@mergify mergify bot added the ready label Mar 21, 2023
@Borda Borda disabled auto-merge March 28, 2023 10:10
@Borda Borda merged commit 6756b74 into master Mar 28, 2023
@Borda Borda deleted the bugfix/dtype_auroc branch March 28, 2023 10:10
@mergify mergify bot added ready and removed ready labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUROC for binary task, if thresholds is set, results in an error
3 participants