Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Removes buffers from state dict #1728

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1724

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Apr 23, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone Apr 23, 2023
@Borda Borda enabled auto-merge (squash) April 26, 2023 06:11
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1728 (a96ca96) into master (b3c8ebb) will not change coverage.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1728   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         250     250           
  Lines       14008   14008           
======================================
  Hits        12251   12251           
  Misses       1757    1757           

@mergify mergify bot added the ready label Apr 26, 2023
@Borda Borda disabled auto-merge April 26, 2023 12:30
@Borda Borda merged commit c3628b0 into master Apr 26, 2023
@Borda Borda deleted the bugfix/non_empty_buffer branch April 26, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUROC thresholds are persistent
2 participants