Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate is_multiclass #194

Merged
merged 2 commits into from
Apr 21, 2021
Merged

deprecate is_multiclass #194

merged 2 commits into from
Apr 21, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 21, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

ANother deprecation round...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #194 (65d93b8) into master (4483658) will decrease coverage by 0.12%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   96.75%   96.63%   -0.13%     
==========================================
  Files         180      180              
  Lines        5728     5760      +32     
==========================================
+ Hits         5542     5566      +24     
- Misses        186      194       +8     
Flag Coverage Δ
Linux 79.93% <78.94%> (-0.03%) ⬇️
Windows 79.93% <78.94%> (-0.03%) ⬇️
cpu 96.63% <78.94%> (-0.13%) ⬇️
gpu 96.63% <ø> (-0.13%) ⬇️
macOS 96.63% <78.94%> (-0.13%) ⬇️
pytest 96.63% <78.94%> (-0.13%) ⬇️
python3.6 95.54% <78.94%> (-0.12%) ⬇️
python3.8 96.59% <78.94%> (-0.13%) ⬇️
python3.9 96.49% <78.94%> (-0.13%) ⬇️
torch1.3.1 95.54% <78.94%> (-0.12%) ⬇️
torch1.4.0 95.65% <78.94%> (-0.12%) ⬇️
torch1.8.1 96.49% <78.94%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/utilities/__init__.py 68.75% <50.00%> (-20.14%) ⬇️
torchmetrics/classification/precision_recall.py 100.00% <100.00%> (ø)
torchmetrics/classification/stat_scores.py 100.00% <100.00%> (ø)
...rics/functional/classification/precision_recall.py 100.00% <100.00%> (ø)
...chmetrics/functional/classification/stat_scores.py 100.00% <100.00%> (ø)
__w/1/s/torchmetrics/utilities/__init__.py 68.75% <0.00%> (-20.14%) ⬇️
__w/1/s/torchmetrics/classification/stat_scores.py 100.00% <0.00%> (ø)
.../s/torchmetrics/classification/precision_recall.py 100.00% <0.00%> (ø)
...chmetrics/functional/classification/stat_scores.py 100.00% <0.00%> (ø)
...rics/functional/classification/precision_recall.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4483658...65d93b8. Read the comment docs.

@Borda Borda merged commit 383439c into master Apr 21, 2021
@Borda Borda deleted the deprecated/is_multiclass branch April 21, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants