Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add average to curve metrics #2084

Merged
merged 20 commits into from
Oct 4, 2023
Merged

Add average to curve metrics #2084

merged 20 commits into from
Oct 4, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 18, 2023

What does this PR do?

I personally needed a way to average pr-curves and roc-curves to make it easy to visualize the overall performance even for many classes. So I found a procedure from sklearn on how to do it and implemented it in TM.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2084.org.readthedocs.build/en/2084/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Sep 18, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Sep 18, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Classif labels Sep 18, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review September 23, 2023 17:29
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2084 (966c91a) into master (2387f2a) will increase coverage by 0%.
The diff coverage is 96%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2084   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         293     293           
  Lines       16323   16371   +48     
======================================
+ Hits        14183   14230   +47     
- Misses       2140    2141    +1     

src/torchmetrics/classification/auroc.py Show resolved Hide resolved
src/torchmetrics/utilities/compute.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Sep 25, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@Borda Borda enabled auto-merge (squash) September 25, 2023 20:31
@Borda Borda merged commit b12a647 into master Oct 4, 2023
66 checks passed
@Borda Borda deleted the curve_average branch October 4, 2023 10:10
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Oct 4, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Oct 14, 2023
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda added a commit to matsumotosan/metrics that referenced this pull request May 21, 2024
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request ready topic: Classif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants