Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @matsumotosan to core #2116

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Sep 28, 2023

What does this PR do?

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2116.org.readthedocs.build/en/2116/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 28, 2023
@matsumotosan matsumotosan marked this pull request as ready for review September 28, 2023 09:53
@mergify mergify bot added the ready label Sep 28, 2023
@Borda Borda changed the title add shion add @matsumotosan to core Sep 28, 2023
@Borda Borda merged commit e55fd0c into Lightning-AI:master Sep 28, 2023
72 of 76 checks passed
@matsumotosan matsumotosan deleted the add-shion branch September 28, 2023 12:55
Borda pushed a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit e55fd0c)
Borda pushed a commit that referenced this pull request Dec 1, 2023
(cherry picked from commit e55fd0c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants