Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy import in image/multimodal domains #2215

Merged
merged 16 commits into from
Nov 28, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 14, 2023

What does this PR do?

Fixes #2171

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2215.org.readthedocs.build/en/2215/

@Borda Borda marked this pull request as draft November 21, 2023 14:31
@Borda Borda added the refactoring refactoring and code health label Nov 21, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review November 25, 2023 18:03
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #2215 (5068d84) into master (cb1666a) will decrease coverage by 45%.
Report is 1 commits behind head on master.
The diff coverage is 56%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2215     +/-   ##
========================================
- Coverage      87%     42%    -45%     
========================================
  Files         293     293             
  Lines       16426   16432      +6     
========================================
- Hits        14277    6853   -7424     
- Misses       2149    9579   +7430     

@mergify mergify bot added the ready label Nov 25, 2023
@SkafteNicki SkafteNicki merged commit 46dfa42 into master Nov 28, 2023
61 checks passed
@SkafteNicki SkafteNicki deleted the lazy_image_multimodal branch November 28, 2023 14:19
Borda pushed a commit that referenced this pull request Nov 30, 2023
* lazy multimodal

* lazy image

* fix import logic

* fix import logic

* revert

* fixes

* fixes

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 46dfa42)
Borda pushed a commit that referenced this pull request Dec 1, 2023
* lazy multimodal

* lazy image

* fix import logic

* fix import logic

* revert

* fixes

* fixes

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 46dfa42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready refactoring refactoring and code health topic: Image topic: MModal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor imports for optional dependencies to be lazy
3 participants