Lazy import text #2216
Merged
Lazy import text #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Borda
approved these changes
Nov 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2216 +/- ##
========================================
- Coverage 87% 42% -45%
========================================
Files 293 293
Lines 16423 16426 +3
========================================
- Hits 14279 6847 -7432
- Misses 2144 9579 +7435 |
carmocca
approved these changes
Nov 27, 2023
Comment on lines
+27
to
+30
| if _TQDM_AVAILABLE: | ||
| import tqdm | ||
| if _TRANSFORMERS_GREATER_EQUAL_4_4: | ||
| from transformers import PreTrainedModel, PreTrainedTokenizerBase |
There was a problem hiding this comment.
AFAIK, under TYPE_CHECKING the other checks do not matter
Suggested change
| if _TQDM_AVAILABLE: | |
| import tqdm | |
| if _TRANSFORMERS_GREATER_EQUAL_4_4: | |
| from transformers import PreTrainedModel, PreTrainedTokenizerBase | |
| import tqdm | |
| from transformers import PreTrainedModel, PreTrainedTokenizerBase |
Borda
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit bb024f6)
Borda
pushed a commit
that referenced
this pull request
Dec 1, 2023
(cherry picked from commit bb024f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2171
Fixes #2242
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2216.org.readthedocs.build/en/2216/