Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for expectation of custom feature extrator in FID metric #2277

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Dec 20, 2023

What does this PR do?

Fixes #2266

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2277.org.readthedocs.build/en/2277/

@SkafteNicki SkafteNicki added bug / fix Something isn't working documentation Improvements or additions to documentation labels Dec 20, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Dec 20, 2023
@github-actions github-actions bot added topic: Image and removed documentation Improvements or additions to documentation labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Merging #2277 (5765495) into master (4059085) will decrease coverage by 46%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2277     +/-   ##
========================================
- Coverage      87%     41%    -46%     
========================================
  Files         300     300             
  Lines       16969   16971      +2     
========================================
- Hits        14737    6970   -7767     
- Misses       2232   10001   +7769     

@mergify mergify bot added the ready label Dec 20, 2023
@stancld stancld merged commit 7543641 into master Dec 22, 2023
60 checks passed
@stancld stancld deleted the bugfix/fid_num_features branch December 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dummy_image in FID doesn't fit into custom feature extractors
3 participants