fix ignored custom callable in retrieval metric aggregation #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschlatt
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Borda
changed the title
Borda
approved these changes
Feb 8, 2024
|
nice, can you pls add test to cover this bug |
|
Tests already exist. The tests compare the computed metric with a reference metric computed using sklearn. The problem is that the computed and reference metrics are aggregated using the same faulty aggregation function. I would propose to copy the fixed aggregation function into the tests. That seems redundant, though. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2364 +/- ##
========================================
- Coverage 69% 35% -34%
========================================
Files 305 305
Lines 17164 17164
========================================
- Hits 11835 5955 -5880
- Misses 5329 11209 +5880 |
SkafteNicki
approved these changes
Feb 9, 2024
Borda
pushed a commit
that referenced
this pull request
Feb 12, 2024
* fix retrieval aggregation * fix retrieval tests * changelog --------- Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> (cherry picked from commit dce2368)
Borda
pushed a commit
that referenced
this pull request
Feb 12, 2024
* fix retrieval aggregation * fix retrieval tests * changelog --------- Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> (cherry picked from commit dce2368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2363
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2364.org.readthedocs.build/en/2364/