-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metric tracker #238
metric tracker #238
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 96.01% 95.96% -0.06%
==========================================
Files 126 127 +1
Lines 4088 4134 +46
==========================================
+ Hits 3925 3967 +42
- Misses 163 167 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello @rajs96! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-04 09:27:08 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, but I am basically missing a bit of context.
Could you provide an example on how it is intended to be used
@rajs96 could you also add to the PR description add a use-case/application? |
@rajs96 how is it going here? |
for more information, see https://pre-commit.ci
Before submitting
What does this PR do?
Adds timeseries metric to the library. Resolves #180
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃