Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perplexity docs #2391

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Fix Perplexity docs #2391

merged 1 commit into from
Feb 17, 2024

Conversation

AtomicVar
Copy link
Contributor

@AtomicVar AtomicVar commented Feb 17, 2024

What does this PR do?

Fixes the docs of Perplexity: it has incorrect indentation so it's not rendered right.

Before the fix:

before

After the fix:

after

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

No. Building the docs is hard for me. I cannot install the lai-sphinx-theme package easily. I refered to pytorch-lightning's Makefile to figure out that it can be installed using AWS S3 CLI.


📚 Documentation preview 📚: https://torchmetrics--2391.org.readthedocs.build/en/2391/

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Merging #2391 (b72b0b8) into master (4c999b8) will decrease coverage by 29%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2391     +/-   ##
========================================
- Coverage      69%     40%    -29%     
========================================
  Files         307     307             
  Lines       17352   17352             
========================================
- Hits        11961    6923   -5038     
- Misses       5391   10429   +5038     

@mergify mergify bot added the ready label Feb 17, 2024
@stancld stancld merged commit 7e2ebff into Lightning-AI:master Feb 17, 2024
59 checks passed
Borda pushed a commit that referenced this pull request Mar 16, 2024
Fix indentation

(cherry picked from commit 7e2ebff)
Borda pushed a commit that referenced this pull request Mar 18, 2024
Fix indentation

(cherry picked from commit 7e2ebff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants