Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: make __getattr__ and __setattr__ of ClasswiseWrapper more general #2424

Merged
merged 11 commits into from
Mar 5, 2024

Conversation

daniel-code
Copy link
Contributor

@daniel-code daniel-code commented Mar 5, 2024

What does this PR do?

Fixes #2389

Related PR: #2390

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2424.org.readthedocs.build/en/2424/

@daniel-code
Copy link
Contributor Author

daniel-code commented Mar 5, 2024

Dear @Borda and @SkafteNicki,

This PR makes __getattr__ and __setattr__ of ClasswiseWrapper more general to fetch the attributes of inner metric and ClasswiseWrapper.

@Borda Borda changed the title Feat: make __getattr__ and __setattr__ of ClasswiseWrapper more general Feat: make __getattr__ and __setattr__ of ClasswiseWrapper more general Mar 5, 2024
@Borda Borda added the enhancement New feature or request label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #2424 (e14c59c) into master (1951a06) will decrease coverage by 34%.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2424     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         307     307             
  Lines       17363   17363             
========================================
- Hits        11961    6050   -5911     
- Misses       5402   11313   +5911     

@SkafteNicki SkafteNicki added this to the v1.3.x milestone Mar 5, 2024
@Borda Borda enabled auto-merge (squash) March 5, 2024 13:53
@Borda Borda merged commit 9d76f3f into Lightning-AI:master Mar 5, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricCollection did not copy inner state of metric in ClasswiseWrapper when computing groups metrics
3 participants