-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in ergas calculation #2498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering how the tests are passing before and now with two different computation...
Because the reference implementation was also written by us (because no reference seems to exist) which had the same computational bug |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2498 +/- ##
========================================
- Coverage 69% 38% -31%
========================================
Files 307 307
Lines 17396 17396
========================================
- Hits 11981 6659 -5322
- Misses 5415 10737 +5322 |
What does this PR do?
Fixes #2497
Fixes #2416
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2498.org.readthedocs.build/en/2498/