Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrapper not working with kwargs arguments #2503

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 14, 2024

What does this PR do?

Fixes #2450

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2503.org.readthedocs.build/en/2503/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Merging #2503 (003a0b8) into master (9e83421) will decrease coverage by 34%.
Report is 1 commits behind head on master.
The diff coverage is 0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2503     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         307     307             
  Lines       17396   17396             
========================================
- Hits        11981    6060   -5921     
- Misses       5415   11336   +5921     

@mergify mergify bot added the ready label Apr 14, 2024
@SkafteNicki SkafteNicki enabled auto-merge (squash) April 15, 2024 10:35
@mergify mergify bot removed the has conflicts label Apr 15, 2024
@SkafteNicki SkafteNicki merged commit 6e088fe into master Apr 15, 2024
60 of 62 checks passed
@SkafteNicki SkafteNicki deleted the bugfix/bootstrapper_kwargs branch April 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BootStrapper.update/forward don't process kwargs
3 participants