Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req: move pretty-errors and option for debug extras #2527

Merged
merged 5 commits into from
May 6, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented May 6, 2024

What does this PR do?

Fixes #2431 (comment)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2527.org.readthedocs.build/en/2527/

@Borda Borda requested a review from a team May 6, 2024 11:59
@Borda Borda requested a review from lantiga as a code owner May 6, 2024 12:32
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (c9f2452) to head (5e4d9ab).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2527   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         313     313           
  Lines       17617   17617           
======================================
- Hits        12163   12162    -1     
- Misses       5454    5455    +1     

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 6, 2024
@Borda Borda merged commit b1d519c into master May 6, 2024
68 of 70 checks passed
@Borda Borda deleted the req/pretty-errors branch May 6, 2024 17:40
baskrahmer pushed a commit to baskrahmer/torchmetrics that referenced this pull request May 13, 2024
…#2527)

* move `pretty-errors` and option for `debug`
* relax

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda added a commit that referenced this pull request May 15, 2024
* move `pretty-errors` and option for `debug`
* relax

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit b1d519c)
@adamjstewart
Copy link
Contributor

Thanks for the release! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants