Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better errors when wrong input is received in detection intersection metrics #2577

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 31, 2024

What does this PR do?

Fixes #2534

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2577.org.readthedocs.build/en/2577/

@SkafteNicki SkafteNicki added the enhancement New feature or request label May 31, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (6a23b38) to head (d9ec798).
Report is 95 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6a23b38) and HEAD (d9ec798). Click for more details.

HEAD has 232 uploads less than BASE
Flag BASE (6a23b38) HEAD (d9ec798)
Windows 12 3
python3.8 12 3
cpu 78 20
torch1.13.1+cpu 12 3
macOS 19 5
python3.10 19 5
torch2.0.1 7 2
torch2.3.0 4 1
python3.11 16 4
torch1.12.1+cpu 4 1
Linux 47 12
python3.9 31 8
torch1.11.0+cpu 4 1
torch1.10.2+cpu 4 1
torch2.3.0+cpu 11 3
torch2.0.1+cpu 12 3
torch1.13.1 4 1
torch2.1.2+cpu 4 1
torch2.2.2+cpu 8 2
torch2.2.2 4 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2577     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         314     314             
  Lines       17679   17695     +16     
========================================
- Hits        12189    6346   -5843     
- Misses       5490   11349   +5859     

@mergify mergify bot added the ready label May 31, 2024
@Borda Borda merged commit f1a2be7 into master Jun 4, 2024
61 checks passed
@Borda Borda deleted the feature/errors_on_wrong_shape_intersection branch June 4, 2024 10:50
Borda pushed a commit that referenced this pull request Aug 2, 2024
…ion metrics (#2577)

* checks
* tests
* changelog

(cherry picked from commit f1a2be7)
Borda pushed a commit that referenced this pull request Aug 2, 2024
…ion metrics (#2577)

* checks
* tests
* changelog

(cherry picked from commit f1a2be7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intersection_over_union error
2 participants