Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-output argument in MAE #2605

Merged
merged 12 commits into from
Jul 22, 2024

Conversation

Astraightrain
Copy link
Contributor

@Astraightrain Astraightrain commented Jun 19, 2024

What does this PR do?

Fixes #2604

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

In multi-output regression tasks, it is essential to evaluate the model's performance for each output individually. Adding the num_outputs argument to the MAE calculation will provide more granular insights into the model's accuracy across multiple outputs, similar to the existing MSE calculation. This enhancement will help users better understand and optimize their models.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Very fun!
Make sure you had fun coding 🙃

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SkafteNicki SkafteNicki added this to the v1.4.x milestone Jul 21, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (e81c218) to head (ca6a6a7).
Report is 101 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2605     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         316     316             
  Lines       17874   17881      +7     
========================================
- Hits        12325    6424   -5901     
- Misses       5549   11457   +5908     

@Borda Borda enabled auto-merge (squash) July 22, 2024 07:32
@mergify mergify bot added the ready label Jul 22, 2024
@Borda Borda merged commit 55f036e into Lightning-AI:master Jul 22, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi output functionality for MeanAbsoluteError
3 participants