Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tracker higher is better integration #2649

Merged
merged 12 commits into from
Aug 6, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 23, 2024

What does this PR do?

Fixes #2545

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2649.org.readthedocs.build/en/2649/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jul 23, 2024
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (f697f35) to head (f9de106).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2649   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         316     316           
  Lines       17729   17745   +16     
======================================
+ Hits        12191   12193    +2     
- Misses       5538    5552   +14     

@mergify mergify bot added the ready label Jul 23, 2024
@mergify mergify bot removed the ready label Aug 5, 2024
@Borda Borda force-pushed the feature/tracker_higher_is_better_integration branch from 9da0a61 to 46cd393 Compare August 5, 2024 14:29
@mergify mergify bot added the ready label Aug 5, 2024
@Borda Borda enabled auto-merge (squash) August 6, 2024 14:57
@Borda Borda merged commit 589916c into master Aug 6, 2024
61 checks passed
@Borda Borda deleted the feature/tracker_higher_is_better_integration branch August 6, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricTracker use higher_is_better as default for maximize
3 participants