Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility audio do with new scipy #2733

Merged
merged 5 commits into from
Sep 11, 2024
Merged

fix: compatibility audio do with new scipy #2733

merged 5 commits into from
Sep 11, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 11, 2024

What does this PR do?

Posting fix #2671 (comment) with compatibility issue:

Traceback (most recent call last):
  File "/__w/4/s/tests/unittests/nominal/test_cramers.py", line 64, in _reference_dython_cramers_v
    from dython.nominal import cramers_v
  File "/usr/local/lib/python3.9/dist-packages/dython/__init__.py", line 1, in <module>
    from . import (
  File "/usr/local/lib/python3.9/dist-packages/dython/model_utils.py", line 4, in <module>
    from scikitplot.helpers import binary_ks_curve
  File "/usr/local/lib/python3.9/dist-packages/scikitplot/__init__.py", line 2, in <module>
    from . import metrics, cluster, decomposition, estimators
  File "/usr/local/lib/python3.9/dist-packages/scikitplot/metrics.py", line 27, in <module>
    from scipy import interp
ImportError: cannot import name 'interp' from 'scipy' (/usr/local/lib/python3.9/dist-packages/scipy/__init__.py)
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2733.org.readthedocs.build/en/2733/

@mergify mergify bot removed the has conflicts label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69%. Comparing base (80929b5) to head (f6a55ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2733   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         329     329           
  Lines       18065   18093   +28     
======================================
+ Hits        12491   12514   +23     
- Misses       5574    5579    +5     

@Borda Borda merged commit 96ceda0 into master Sep 11, 2024
53 of 59 checks passed
@Borda Borda deleted the fix/scipy branch September 11, 2024 12:30
Borda added a commit that referenced this pull request Sep 11, 2024
* compatibility audio do with new `scipy`
* smaller array to fix torch.unique case

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Borda added a commit to vkinakh/torchmetrics that referenced this pull request Sep 11, 2024
* compatibility audio do with new `scipy`
* smaller array to fix torch.unique case

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
@Borda Borda mentioned this pull request Sep 11, 2024
4 tasks
Borda added a commit that referenced this pull request Sep 11, 2024
* compatibility audio do with new `scipy`
* smaller array to fix torch.unique case

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
(cherry picked from commit f12e7af)
Borda added a commit that referenced this pull request Sep 13, 2024
* compatibility audio do with new `scipy`
* smaller array to fix torch.unique case

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
(cherry picked from commit f12e7af)
@@ -64,6 +64,7 @@
_MECAB_KO_DIC_AVAILABLE = RequirementCache("mecab_ko_dic")
_IPADIC_AVAILABLE = RequirementCache("ipadic")
_SENTENCEPIECE_AVAILABLE = RequirementCache("sentencepiece")
_SCIPI_AVAILABLE = RequirementCache("scipy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: scipi -> scipy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants