-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_sync logic to Metric #339
Conversation
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-01 17:43:39 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
===========================================
- Coverage 96.37% 75.97% -20.41%
===========================================
Files 111 112 +1
Lines 3586 3600 +14
===========================================
- Hits 3456 2735 -721
- Misses 130 865 +735
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, some comments :)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
@tchaton Model saving after DDP training is working fine with this fix. Tested for single and multi-gpus. |
Before submitting
What does this PR do?
This PR makes synchornization, state_dict and load_dict generation fully manual for the users, so they have full control on their metric states.
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃