-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _sync_dist for compositional metrics #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
August 17, 2021 08:54
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
===========================================
+ Coverage 74.94% 95.90% +20.96%
===========================================
Files 129 129
Lines 4227 4227
===========================================
+ Hits 3168 4054 +886
+ Misses 1059 173 -886
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
approved these changes
Aug 17, 2021
justusschock
approved these changes
Aug 17, 2021
…rchLightning/metrics into fix_compositional_sync_dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #438
self._sync_dist
in compositional metrics have a different signature as the base class. Compare this:https://github.com/PyTorchLightning/metrics/blob/1171a1f12507df5c8206475f3692b31ddab8d934/torchmetrics/metric.py#L216
to this:
https://github.com/PyTorchLightning/metrics/blob/1171a1f12507df5c8206475f3692b31ddab8d934/torchmetrics/metric.py#L666
which leads to the error:
TypeError: _sync_dist() got an unexpected keyword argument 'process_group'
This PR fixes it and add test.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃