Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make metric_mtx type and device correct #533

Merged
merged 8 commits into from
Sep 22, 2021
Merged

make metric_mtx type and device correct #533

merged 8 commits into from
Sep 22, 2021

Conversation

quancs
Copy link
Member

@quancs quancs commented Sep 18, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

fix #534

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #533 (31198e8) into master (d6112a2) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #533   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         132    132           
  Lines        4676   4680    +4     
=====================================
+ Hits         4457   4461    +4     
  Misses        219    219           

@Borda Borda added the enhancement New feature or request label Sep 18, 2021
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot removed the has conflicts label Sep 22, 2021
@Borda Borda enabled auto-merge (squash) September 22, 2021 08:35
@mergify mergify bot added the ready label Sep 22, 2021
@Borda Borda merged commit f9d7d5f into Lightning-AI:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pit bug: the device and type of preds and target may not the same with the results returned by metric_func
4 participants