-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix child device #542
Merged
Merged
Fix child device #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
ethanwharris,
justusschock,
SeanNaren and
tchaton
as code owners
September 21, 2021 17:37
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=====================================
Coverage 95% 95%
=====================================
Files 132 132
Lines 4680 4660 -20
=====================================
- Hits 4461 4444 -17
+ Misses 219 216 -3 |
for more information, see https://pre-commit.ci
@SkafteNicki Thank you for working on this fix! |
@cowwoc if you have the time, please confirm that this fixes your original issue :] |
justusschock
approved these changes
Sep 22, 2021
Thanks @SkafteNicki! |
Borda
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #531
Currently if a metric is a child of a module, the
device
property (only the property, the metric states are still correctly updated) of the metric will not get properly update (only if.cuda()
,.cpu()
,to()
is directly called on the metric) when calling.cuda()
on the module. This PR fixes it.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃