Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make is_differentiable as attribute #551

Merged
merged 8 commits into from
Sep 27, 2021
Merged

make is_differentiable as attribute #551

merged 8 commits into from
Sep 27, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 25, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Implements #544 (comment)
cc: @SkafteNicki

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #551 (dedb16b) into master (fbdc3eb) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #551   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         130    130           
  Lines        4690   4618   -72     
=====================================
- Hits         4472   4397   -75     
- Misses        218    221    +3     

@mergify mergify bot added the ready label Sep 26, 2021
@Borda Borda self-assigned this Sep 26, 2021
@Borda Borda added this to the v0.6 milestone Sep 26, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

torchmetrics/metric.py Outdated Show resolved Hide resolved
Co-authored-by: thomas chaton <thomas@grid.ai>
@Borda Borda enabled auto-merge (squash) September 27, 2021 11:40
@Borda Borda merged commit ac52dd7 into master Sep 27, 2021
@Borda Borda deleted the is_diff branch September 27, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants