Add SQuAD Metric. #623
Merged
Add SQuAD Metric. #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikrangasai
requested review from
ananyahjha93,
Borda,
edenlightning,
ethanwharris,
justusschock,
SeanNaren,
SkafteNicki and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 153 155 +2
Lines 5395 5508 +113
======================================
+ Hits 5133 5240 +107
- Misses 262 268 +6 |
|
@stancld mind have look :] |
SkafteNicki
reviewed
Nov 15, 2021
stancld
reviewed
Nov 15, 2021
There was a problem hiding this comment.
Thank you @karthikrangasai for your PR :] I've added some minor comments. There are also some missing annotations for input args.
But in general, looks good :]
stancld
reviewed
Nov 15, 2021
stancld
reviewed
Nov 15, 2021
stancld
reviewed
Nov 15, 2021
stancld
reviewed
Nov 16, 2021
SkafteNicki
reviewed
Nov 17, 2021
stancld
reviewed
Nov 17, 2021
Borda
reviewed
Nov 18, 2021
Borda
reviewed
Nov 18, 2021
Borda
reviewed
Nov 18, 2021
Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
Borda
reviewed
Nov 18, 2021
Borda
approved these changes
Nov 18, 2021
Borda
reviewed
Nov 18, 2021
stancld
approved these changes
Nov 20, 2021
SkafteNicki
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #366
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃