-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChrF++
#641
Add ChrF++
#641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 159 161 +2
Lines 5584 5781 +197
======================================
+ Hits 5315 5499 +184
- Misses 269 282 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot comment much on the implementation since I am not that much into NLP, but since you test that against another lib I assume it to be fine :)
Just a very minor question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing question :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only some typing issues remain :]
(please see the failing test for more info)
What does this PR do?
This PR adds a new text evaluation metric -
ChrF++
.Fixes #634
REF: https://github.com/m-popovic/chrF/blob/master/chrF%2B%2B.py
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃