-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Reference ROUGEScore #680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 166 166
Lines 6379 6413 +34
=====================================
+ Hits 6074 6103 +29
- Misses 305 310 +5 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @ashutoshml, thank you very much for your contribution. :] I left some minor comments. I will also need to consider averaging methods a bit more, but they're likely okay.
Also, I think you can update CHANGELOG.md
with a note that we allow a user to evaluate against multiple references.
Based on the current checks, it seems like the build is literally failing because of the absence of "Literal" typing in python<=3.7. Kindly let me know if it needs to be removed. |
@ashutoshml Hi, |
Done. Hopefully, the errors would be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashutoshml Nice, it looks good to me now. Also, thanks a lot for replacing List
type annotations for more general Sequence
annotations "]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ix typo Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Made the necessary changes from review comments. Not sure why the |
What does this PR do?
Fixes #667
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Yes.