Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename CorrCoef #710

Merged
merged 3 commits into from
Jan 6, 2022
Merged

rename CorrCoef #710

merged 3 commits into from
Jan 6, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 4, 2022

What does this PR do?

For consistency keep camel case strict corrcoef -> CorrCoef as it it Correlation Coerficient
part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from edenlightning as a code owner January 4, 2022 22:41
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #710 (f7c9cbd) into master (89f603b) will decrease coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff          @@
##           master   #710   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         166    166           
  Lines        6424   6439   +15     
=====================================
- Hits         6117   6110    -7     
- Misses        307    329   +22     

@Borda Borda self-assigned this Jan 5, 2022
@Borda Borda added this to the v0.7 milestone Jan 5, 2022
@mergify mergify bot added the ready label Jan 5, 2022
@Borda Borda merged commit 30e33c2 into master Jan 6, 2022
@Borda Borda deleted the refactor/corrcoer branch January 6, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants