Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename permutation_invariant_training #737

Merged
merged 29 commits into from
Jan 12, 2022
Merged

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Jan 10, 2022

To unify pit to permutation_invariant_training

What does this PR do?

Part of #729, To unify pit to permutation_invariant_training

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

To unify `pit` to `permutation_invariant_training`
@Borda Borda changed the title Unify functional metrics names #729 rename permutation_invariant_training Jan 10, 2022
@Borda Borda added API / design refactoring refactoring and code health labels Jan 10, 2022
@Borda Borda mentioned this pull request Jan 10, 2022
12 tasks
@Borda Borda added this to the v0.7 milestone Jan 10, 2022
@Borda Borda marked this pull request as draft January 10, 2022 15:29
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, bear in mind we need to keep PIT and pit for backward compatibility. Please see #731 :]


  • deprecation warnings & back compatibility
  • add changelog

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #737 (51406af) into master (d36fffc) will decrease coverage by 0%.
The diff coverage is 83%.

@@          Coverage Diff          @@
##           master   #737   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         169    169           
  Lines        6725   6733    +8     
=====================================
+ Hits         6389   6395    +6     
- Misses        336    338    +2     

@puhuk puhuk marked this pull request as ready for review January 11, 2022 02:00
torchmetrics/functional/audio/pit.py Outdated Show resolved Hide resolved
torchmetrics/functional/audio/pit.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from stancld January 11, 2022 09:20
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're some remaining flake8 issues:

Run flake8 .
./torchmetrics/audio/pit.py:19: [F401] 'torchmetrics.functional.audio.pit.pit' imported but unused
./torchmetrics/audio/pit.py:64: [F811] redefinition of unused 'pit' from line 19
./torchmetrics/audio/pit.py:130: [F811] redefinition of unused 'pit' from line 19

but otherwise, it looks pretty good :]

@Borda
Copy link
Member

Borda commented Jan 11, 2022

@stancld fixed now 🐰

@Borda Borda enabled auto-merge (squash) January 11, 2022 23:34
@mergify mergify bot added the ready label Jan 12, 2022
@Borda Borda merged commit abba3ea into Lightning-AI:master Jan 12, 2022
@puhuk puhuk deleted the unify_pit branch January 15, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants