-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename permutation_invariant_training
#737
Conversation
To unify `pit` to `permutation_invariant_training`
for more information, see https://pre-commit.ci
permutation_invariant_training
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, bear in mind we need to keep PIT
and pit
for backward compatibility. Please see #731 :]
- deprecation warnings & back compatibility
- add changelog
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 169 169
Lines 6725 6733 +8
=====================================
+ Hits 6389 6395 +6
- Misses 336 338 +2 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There're some remaining flake8 issues:
Run flake8 .
./torchmetrics/audio/pit.py:19: [F401] 'torchmetrics.functional.audio.pit.pit' imported but unused
./torchmetrics/audio/pit.py:64: [F811] redefinition of unused 'pit' from line 19
./torchmetrics/audio/pit.py:130: [F811] redefinition of unused 'pit' from line 19
but otherwise, it looks pretty good :]
@stancld fixed now 🐰 |
To unify
pit
topermutation_invariant_training
What does this PR do?
Part of #729, To unify
pit
topermutation_invariant_training
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃