Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename PESQ #751

Merged
merged 6 commits into from
Jan 14, 2022
Merged

rename PESQ #751

merged 6 commits into from
Jan 14, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 14, 2022

What does this PR do?

rename PESQ for consistency
part of #729

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #751 (feeab60) into master (daf7581) will decrease coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff          @@
##           master   #751   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         170    170           
  Lines        6806   6823   +17     
=====================================
+ Hits         6445   6460   +15     
- Misses        361    363    +2     

@Borda Borda changed the title Refactor: PESQ rename PESQ Jan 14, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready label Jan 14, 2022
@Borda Borda enabled auto-merge (squash) January 14, 2022 10:57
torchmetrics/audio/pesq.py Outdated Show resolved Hide resolved
torchmetrics/audio/pesq.py Outdated Show resolved Hide resolved
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@Borda Borda self-assigned this Jan 14, 2022
@Borda Borda disabled auto-merge January 14, 2022 13:26
@Borda Borda merged commit 06d820b into master Jan 14, 2022
@Borda Borda deleted the refactor/pesq branch January 14, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants