todo

Lightning-AI · Dec 19, 2022 · ea47562 · ea47562
1 parent a8620c1
commit ea47562
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/check-package.yml b/.github/workflows/check-package.yml
@@ -11,10 +11,6 @@ on:
         description: 'Import name to test with after installation'
         required: true
         type: string
-      pypi-name:
-        description: 'PyPI name to install the package with'
-        required: true
-        type: string
       install-flags:
         description: 'Additional pip install flags'
         required: false
@@ -132,3 +128,5 @@ jobs:
           # TODO: reset env / conside add as conda
           pip install *.whl ${{ inputs.install-flags }}
           python -c "import ${{ inputs.import-name }}; print(${{ inputs.import-name }}.__version__)"
+
+      # TODO: add run doctests
diff --git a/.github/workflows/ci-use-checks.yml b/.github/workflows/ci-use-checks.yml
@@ -22,8 +22,8 @@ jobs:
   check-package:
     uses: ./.github/workflows/check-package.yml
     with:
+      artifact-name: dist-packages-${{ github.sha }}
       import-name: "lightning_utilities"
-      pypi-name: "lightning-utilities"  # todo: seems it does not have effect if you set it wrong
 
   check-docs:
     uses: ./.github/workflows/check-docs.yml