Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid accidental namedtuple conversion in apply_to_collection #210

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Avoid accidental namedtuple conversion in apply_to_collection #210

merged 5 commits into from
Dec 20, 2023

Conversation

GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Dec 18, 2023 •
edited by Borda
Loading

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

Fixes #196 fixes #206

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

📚 Documentation preview 📚: https://lit-utilities--210.org.readthedocs.build/en/210/

@Borda Borda changed the title fix: fix #196, convert to original class if possible in `apply_to_col… fix: convert to original class if possible in apply_to_collection Dec 18, 2023
@artbataev
Copy link

@GdoongMathew can you also please add a test with a named tuple?

@GdoongMathew
Copy link
Contributor Author

Hi, @artbataev
namedtuple test case has been added.
Thanks.

carmocca
carmocca approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carmocca carmocca enabled auto-merge (squash) December 20, 2023 16:42
@carmocca carmocca changed the title fix: convert to original class if possible in apply_to_collection Avoid accidental namedtuple conversion in apply_to_collection Dec 20, 2023
@carmocca carmocca merged commit 990ba45 into Lightning-AI:main Dec 20, 2023
46 checks passed
@artbataev
Copy link

@GdoongMathew, @carmocca thanks a lot!

@artbataev artbataev mentioned this pull request Dec 20, 2023
Merged
8 tasks
@Borda Borda mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

Assignees
No one assigned
Labels
package tests
Projects
None yet
Milestone
No milestone
3 participants
@GdoongMathew @artbataev @carmocca