Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: do not replace link for self #245

Merged
merged 8 commits into from
Mar 25, 2024
Merged

docs: do not replace link for self #245

merged 8 commits into from
Mar 25, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 25, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

debugging https://readthedocs.org/projects/lit-utilities/builds/23859566/
seems like https://pytorch.org/docs/stable/objects.inv is not the same as https://pytorch.org/docs/1.26/objects.inv even this is the latest at this time

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--245.org.readthedocs.build/en/245/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 25, 2024
@Borda
Copy link
Member Author

Borda commented Mar 25, 2024

interesting that the build does not have any separation between PR and normal run but in PR ut does not replace stable even on the main branch it does... :/

@Borda
Copy link
Member Author

Borda commented Mar 25, 2024

even running with hardcoded 1.26 it passed https://readthedocs.org/projects/lit-utilities/builds/23861642/

@Borda Borda changed the title ci/docs: debug links docs: do not replace link for self Mar 25, 2024
@Borda Borda marked this pull request as ready for review March 25, 2024 13:00
@Borda Borda merged commit c8544d4 into main Mar 25, 2024
45 checks passed
@Borda Borda deleted the docs/build branch March 25, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant