Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix parsing non-trivial package name #247

Merged
merged 3 commits into from
Mar 27, 2024
Merged

docs: fix parsing non-trivial package name #247

merged 3 commits into from
Mar 27, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

addressing #243 when package name is not trivial
discovered in Lightning-AI/torchmetrics#2476

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--247.org.readthedocs.build/en/247/

@Borda Borda added the bug Something isn't working label Mar 27, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation package tests labels Mar 27, 2024
@Borda Borda merged commit 7c9f6c4 into main Mar 27, 2024
45 checks passed
@Borda Borda deleted the docs/fix-parsing branch March 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants