Fix extras check in RequirementCache #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
reviewed
Jul 15, 2024
Borda
approved these changes
Jul 15, 2024
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #281 I made the implementation for RequirementCache to not depend on
pkg_resources, but this accidentally broke checks against extras. For example:would currently return true regardless of whether the signatures dependencies are installed or not. This is because
pkg_resourceswas previously handling this directly. This PR brings this functionality back. Hopefully there are no other breakages.📚 Documentation preview 📚: https://lit-utilities--283.org.readthedocs.build/en/283/