Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing pre-release package versions #292

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Fix parsing pre-release package versions #292

merged 4 commits into from
Jul 23, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 23, 2024

When we replaced the deprecated pkg_resources version parsing in #281, we replaced the version comparison. The previous way implicitly handled pre-release version specifications, like 1.10.0.dev0+931b44f for example. This functionality got accidentally lost (but wasn't tested before). This PR restores this so that we don't break version parsing. The added test fails on main.

Raised in Lightning-AI/lightning-thunder#809


📚 Documentation preview 📚: https://lit-utilities--292.org.readthedocs.build/en/292/

@awaelchli awaelchli changed the title parse pre-releases Fix parsing pre-release package versions Jul 23, 2024
@Borda
Copy link
Member

Borda commented Jul 23, 2024

plus pls add chlog.. 🐰

@Borda Borda merged commit f0fa61e into main Jul 23, 2024
45 checks passed
@Borda Borda deleted the bugfix/parse-te branch July 23, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants