Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add requires wrapper #70

Merged
merged 14 commits into from
Dec 13, 2022
Merged

add requires wrapper #70

merged 14 commits into from
Dec 13, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 28, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adding a handy wrapper to provide better user error...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/lightning_utilities/core/imports.py Outdated Show resolved Hide resolved
@akihironitta akihironitta added the enhancement New feature or request label Nov 29, 2022
@Borda Borda disabled auto-merge November 29, 2022 22:14
@Borda Borda requested a review from carmocca December 5, 2022 14:37
@Borda Borda enabled auto-merge (squash) December 5, 2022 14:57
src/lightning_utilities/core/imports.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from carmocca December 6, 2022 17:02
src/lightning_utilities/core/imports.py Outdated Show resolved Hide resolved
tests/unittests/core/test_imports.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda merged commit fa1981f into main Dec 13, 2022
@Borda Borda deleted the pkg/requires branch December 13, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants