Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactors of the codebase #519

Closed
2 of 9 tasks
akihironitta opened this issue Jan 17, 2021 · 0 comments · Fixed by #524
Closed
2 of 9 tasks

Minor refactors of the codebase #519

akihironitta opened this issue Jan 17, 2021 · 0 comments · Fixed by #524
Assignees
Labels
enhancement New feature or request refactoring
Milestone

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Jan 17, 2021

🚀 Refactoring

This is a tracking issue for minor refactors (which makes sure not to change existing APIs):

  • pragma (see also: [coverage] Use no cover instead of no-cover #476)
    • Use # pragma: no cover instead of # pragma: no-cover.
    • Place # pragma: no cover at the beginning of clauses.
  • imports
    • Add missing __all__ to __init__.py files.
    • Use if/else instead of try/except for optional import statements
    • Raise ModuleNotFoundError with helpful messages when instantiating classes or calling functions in order not to fail to import classes/functions.

Progress

Additional context

After addressing this issue, #427 will follow up for major refactoring in models, and I'll add the importing tests in #421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants