Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactors - datasets/datamodules/optimizers/transforms/metrics/utils #523

Merged
merged 9 commits into from
Jan 18, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 18, 2021

What does this PR do?

Part of #519

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks

This comment has been minimized.

@github-actions github-actions bot added the datamodule Anything related to datamodules label Jan 18, 2021
@akihironitta akihironitta added refactoring datamodule Anything related to datamodules and removed datamodule Anything related to datamodules labels Jan 18, 2021
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #523 (4a6265a) into master (58aa93a) will decrease coverage by 0.16%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   78.95%   78.79%   -0.17%     
==========================================
  Files         105      105              
  Lines        6121     6144      +23     
==========================================
+ Hits         4833     4841       +8     
- Misses       1288     1303      +15     
Flag Coverage Δ
cpu 25.61% <31.81%> (-0.05%) ⬇️
pytest 25.61% <31.81%> (-0.05%) ⬇️
unittests 78.32% <50.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/cifar10_dataset.py 70.96% <0.00%> (-0.78%) ⬇️
pl_bolts/datasets/kitti_dataset.py 32.69% <0.00%> (ø)
pl_bolts/datasets/mnist_dataset.py 45.45% <25.00%> (-4.55%) ⬇️
pl_bolts/datasets/ssl_amdim_datasets.py 76.31% <50.00%> (-0.72%) ⬇️
pl_bolts/utils/semi_supervised.py 93.93% <50.00%> (-2.94%) ⬇️
pl_bolts/transforms/dataset_normalizations.py 84.21% <62.50%> (-15.79%) ⬇️
pl_bolts/metrics/__init__.py 100.00% <100.00%> (ø)
pl_bolts/optimizers/__init__.py 100.00% <100.00%> (ø)
pl_bolts/utils/pretrained_weights.py 54.54% <100.00%> (-45.46%) ⬇️
pl_bolts/utils/self_supervised.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aa93a...4a6265a. Read the comment docs.

@akihironitta akihironitta changed the title Minor refactor Minor refactors - datasets/datamodules/optimizers/transforms/metrics/utils Jan 18, 2021
@akihironitta akihironitta mentioned this pull request Jan 18, 2021
9 tasks
@akihironitta akihironitta marked this pull request as ready for review January 18, 2021 06:02
@Borda Borda added the ready label Jan 18, 2021
@Borda Borda merged commit 4807ef3 into Lightning-Universe:master Jan 18, 2021
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants