Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Vision DataModules #400

Merged
merged 33 commits into from
Dec 17, 2020
Merged

Refactor Vision DataModules #400

merged 33 commits into from
Dec 17, 2020

Commits on Dec 16, 2020

  1. Add BaseDataModule

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d5d4dda View commit details
    Browse the repository at this point in the history

  2. Add pre-commit hooks

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    4876be0 View commit details
    Browse the repository at this point in the history

  3. Refactor cifar10_datamodule

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9476033 View commit details
    Browse the repository at this point in the history

  4. Move torchvision warning

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0651131 View commit details
    Browse the repository at this point in the history

  5. Refactor binary_mnist_datamodule

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e1f6238 View commit details
    Browse the repository at this point in the history

  6. Refactor fashion_mnist_datamodule

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5b9e2fd View commit details
    Browse the repository at this point in the history

  7. Fix errors

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9ab0640 View commit details
    Browse the repository at this point in the history

  8. Remove VisionDataset type hint so CI base testing does not fail (torc… 

    …hvision is not installed there)
    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    b7840bf View commit details
    Browse the repository at this point in the history

  9. Implement Nate's suggestions

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    4395be3 View commit details
    Browse the repository at this point in the history

  10. Remove train and eval batch size because it brakes a lot of tests

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e82b243 View commit details
    Browse the repository at this point in the history

  11. Properly add transforms to train and val dataset

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    8e9ae04 View commit details
    Browse the repository at this point in the history

  12. Add num_samples property to cifar10 dm

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    790d6e0 View commit details
    Browse the repository at this point in the history

  13. Add tesats and docs

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    7c9b3ce View commit details
    Browse the repository at this point in the history

  14. Fix flake8 and codafactor issue

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    d86f432 View commit details
    Browse the repository at this point in the history

  15. Update changelog

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e5e69e4 View commit details
    Browse the repository at this point in the history

  16. Fix isort

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1d821c2 View commit details
    Browse the repository at this point in the history

  17. Add typing

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    a7d6bd4 View commit details
    Browse the repository at this point in the history

  18. Rename to VisionDataModule

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    1d9fa44 View commit details
    Browse the repository at this point in the history

  19. Remove transform_lib type annotation

    @chris-clem @Borda
    chris-clem authored and Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    6b9bdcb View commit details
    Browse the repository at this point in the history

  20. suggestions

    @Borda
    Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    8ae4907 View commit details
    Browse the repository at this point in the history

  21. Apply suggestions from code review

    @Borda
    Borda committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    4de2ea9 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
    @Borda @akihironitta
    Borda and akihironitta authored Dec 17, 2020
    Configuration menu
    Copy the full SHA
    716dedf View commit details
    Browse the repository at this point in the history

  2. Add flags from Lightning-Universe#388 to API

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    54114c5 View commit details
    Browse the repository at this point in the history

  3. Make tests work

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    be6fb25 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feature/395_refactor-vision-dms

    @chris-clem
    chris-clem authored Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a55ad63 View commit details
    Browse the repository at this point in the history

  5. Move _TORCHVISION_AVAILABLE check

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    25382a2 View commit details
    Browse the repository at this point in the history

  6. Update changelog

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4902c1c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into feature/395_refactor-vision-dms 

    # Conflicts:
#	pl_bolts/datamodules/binary_mnist_datamodule.py
#	pl_bolts/datamodules/cifar10_datamodule.py
#	pl_bolts/datamodules/fashion_mnist_datamodule.py
#	pl_bolts/datamodules/mnist_datamodule.py
    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2d29a1f View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/feature/395_refactor-vision-dms'… 

    … into feature/395_refactor-vision-dms

# Conflicts:
#	pl_bolts/datamodules/cifar10_datamodule.py
#	pl_bolts/datamodules/fashion_mnist_datamodule.py
#	pl_bolts/datamodules/mnist_datamodule.py
    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    26eafdf View commit details
    Browse the repository at this point in the history

  9. Fix CI base testing

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    875f13a View commit details
    Browse the repository at this point in the history

  10. Fix CI base testing

    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    aac84ab View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/feature/395_refactor-vision-dms'… 

    … into feature/395_refactor-vision-dms
    @chris-clem
    chris-clem committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    1d5f0b5 View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review

    @akihironitta
    akihironitta authored Dec 17, 2020
    Configuration menu
    Copy the full SHA
    4cf20b6 View commit details
    Browse the repository at this point in the history