Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update setup with PL #514

Merged
merged 5 commits into from
Jan 15, 2021
Merged

update setup with PL #514

merged 5 commits into from
Jan 15, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 15, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #514 (3ab7501) into master (c43622e) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   79.55%   79.04%   -0.51%     
==========================================
  Files         102      102              
  Lines        5912     5912              
==========================================
- Hits         4703     4673      -30     
- Misses       1209     1239      +30     
Flag Coverage Δ
cpu 25.77% <ø> (ø)
pytest 25.77% <ø> (ø)
unittests 78.55% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/datasets/cifar10_dataset.py 71.73% <0.00%> (-26.09%) ⬇️
pl_bolts/datasets/base_dataset.py 81.81% <0.00%> (-13.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43622e...6e7bed1. Read the comment docs.

@Borda Borda marked this pull request as ready for review January 15, 2021 21:31
@Borda Borda merged commit 25bfadc into master Jan 15, 2021
@Borda Borda deleted the refactor/setup branch January 15, 2021 21:46
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant