Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
todos
Browse files Browse the repository at this point in the history
  • Loading branch information
@Borda
Borda committed May 14, 2023
1 parent 043fcde commit 3c8646d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
3 changes: 1 addition & 2 deletions tests/tabular/classification/test_data_model_integration.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# ("category_embedding", # todo: seems to be bug in tabular
# {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# No categorical / numerical fields
("tabnet", {"categorical_fields": ["category"]}),
("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}),
Expand Down
6 changes: 3 additions & 3 deletions tests/tabular/classification/test_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class TestTabularClassifier(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand All @@ -68,7 +68,7 @@ class TestTabularClassifier(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand All @@ -81,7 +81,7 @@ class TestTabularClassifier(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand Down
9 changes: 3 additions & 6 deletions tests/tabular/regression/test_data_model_integration.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# ("category_embedding", # todo: seems to be bug in tabular
# {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# No categorical / numerical fields
("tabnet", {"categorical_fields": ["category"]}),
("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}),
Expand Down Expand Up @@ -82,8 +81,7 @@ def test_regression_data_frame(backbone, fields, tmpdir):
("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# ("category_embedding", # todo: seems to be bug in tabular
# {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# No categorical / numerical fields
("tabnet", {"categorical_fields": ["category"]}),
("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}),
Expand Down Expand Up @@ -113,8 +111,7 @@ def test_regression_dicts(backbone, fields, tmpdir):
("fttransformer", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("autoint", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("node", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# ("category_embedding", # todo: seems to be bug in tabular
# {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
("category_embedding", {"categorical_fields": ["category"], "numerical_fields": ["scalar_a", "scalar_b"]}),
# No categorical / numerical fields
("tabnet", {"categorical_fields": ["category"]}),
("tabnet", {"numerical_fields": ["scalar_a", "scalar_b"]}),
Expand Down
6 changes: 3 additions & 3 deletions tests/tabular/regression/test_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class TestTabularRegressor(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand All @@ -66,7 +66,7 @@ class TestTabularRegressor(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand All @@ -79,7 +79,7 @@ class TestTabularRegressor(TaskTester):
{"backbone": "fttransformer"},
{"backbone": "autoint"},
{"backbone": "node"},
# {"backbone": "category_embedding"}, # todo: seems to be bug in tabular
{"backbone": "category_embedding"},
],
)
],
Expand Down

0 comments on commit 3c8646d

Please sign in to comment.