Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Clean-up to fix rtd build #1259

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Clean-up to fix rtd build #1259

merged 1 commit into from
Mar 28, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

RTD mocks requirements when it builds the docs. This includes the PL requirement so the LightningEnum gets switched to just a regular type and so doesn't support iteration. The cleans up a bit and avoids the iteration.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Mar 28, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1259 (97a6d71) into master (2dd4903) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1259   +/-   ##
=======================================
  Coverage   91.17%   91.18%           
=======================================
  Files         286      286           
  Lines       12788    12788           
=======================================
+ Hits        11660    11661    +1     
+ Misses       1128     1127    -1     
Flag Coverage Δ
unittests 91.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/finetuning.py 92.20% <100.00%> (ø)
flash/text/question_answering/model.py 92.56% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd4903...97a6d71. Read the comment docs.

@ethanwharris ethanwharris merged commit bfa8b91 into master Mar 28, 2022
@ethanwharris ethanwharris deleted the docs/fix_build_mocked_enum branch March 28, 2022 19:04
ethanwharris added a commit that referenced this pull request Mar 30, 2022
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant