Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix backbone freezing for question answering and speech recognition #1275

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1112

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1275 (890f183) into master (1d926b5) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
+ Coverage   91.30%   91.56%   +0.25%     
==========================================
  Files         285      284       -1     
  Lines       12779    12729      -50     
==========================================
- Hits        11668    11655      -13     
+ Misses       1111     1074      -37     
Flag Coverage Δ
unittests 91.56% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/model.py 100.00% <100.00%> (ø)
flash/text/question_answering/model.py 92.51% <100.00%> (-0.06%) ⬇️
flash/text/question_answering/collate.py 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d926b5...890f183. Read the comment docs.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 🚀 Thanks, @ethanwharris! Just a couple of questions for my knowledge, but shouldn't block merging this PR.

flash/text/question_answering/finetuning.py Show resolved Hide resolved
flash/text/question_answering/model.py Show resolved Hide resolved
@ethanwharris ethanwharris merged commit b88d1ba into master Apr 7, 2022
@ethanwharris ethanwharris deleted the bugfix/speech_backbone branch April 7, 2022 12:48
ethanwharris added a commit that referenced this pull request Apr 13, 2022
…1275)

Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
ethanwharris added a commit that referenced this pull request Apr 13, 2022
…1275)

Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to generate predictions for wav2vec model fine-tuned with custom data
2 participants