Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add fit tests for tabular tasks #1332

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Part of #1183

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the tests / CI Tests and continuous integration label May 6, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1332 (e379bef) into master (07d63e3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   91.47%   91.46%   -0.02%     
==========================================
  Files         287      287              
  Lines       12881    12894      +13     
==========================================
+ Hits        11783    11793      +10     
- Misses       1098     1101       +3     
Flag Coverage Δ
unittests 91.46% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/integrations/pytorch_tabular/adapter.py 96.96% <100.00%> (+0.19%) ⬆️
.../image/classification/integrations/baal/dropout.py 92.30% <0.00%> (-2.94%) ⬇️
...ash/image/classification/integrations/baal/data.py 87.85% <0.00%> (-0.94%) ⬇️
flash/core/utilities/imports.py 91.42% <0.00%> (-0.29%) ⬇️
...ash/image/classification/integrations/baal/loop.py 94.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d63e3...e379bef. Read the comment docs.

@ethanwharris ethanwharris merged commit 48a2500 into master May 6, 2022
@ethanwharris ethanwharris deleted the feature/tabular_fit_test branch May 6, 2022 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant