This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Support from_lists
for Tabular Classification and Regression (lists of dict/tuple)
#1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
ethanwharris,
Borda,
tchaton,
justusschock,
carmocca and
kaushikb11
as code owners
May 9, 2022 15:30
for more information, see https://pre-commit.ci
…lightning-flash into tabular_c_r/from_lists
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
=======================================
Coverage 92.01% 92.02%
=======================================
Files 287 287
Lines 12901 12922 +21
=======================================
+ Hits 11871 11891 +20
- Misses 1030 1031 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ethanwharris
reviewed
May 9, 2022
ethanwharris
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 😃 LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for
from_lists
for tabular classification and regression. Doc artifact links:TabularClassificationData.from_dicts
TabularClassificationData.from_lists
TabularRegressionData.from_dicts
TabularRegressionData.from_lists
Fixes #1326
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃