Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Support from_lists for Tabular Classification and Regression (lists of dict/tuple) #1337

Merged
merged 12 commits into from
May 10, 2022

Conversation

krshrimali
Copy link
Contributor

@krshrimali krshrimali commented May 9, 2022

What does this PR do?

This PR adds support for from_lists for tabular classification and regression. Doc artifact links:

  1. TabularClassificationData.from_dicts
  2. TabularClassificationData.from_lists
  3. TabularRegressionData.from_dicts
  4. TabularRegressionData.from_lists

Fixes #1326

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@krshrimali krshrimali marked this pull request as draft May 9, 2022 15:36
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1337 (750123a) into master (897e31b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1337   +/-   ##
=======================================
  Coverage   92.01%   92.02%           
=======================================
  Files         287      287           
  Lines       12901    12922   +21     
=======================================
+ Hits        11871    11891   +20     
- Misses       1030     1031    +1     
Flag Coverage Δ
unittests 92.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/data.py 97.61% <100.00%> (+0.47%) ⬆️
flash/tabular/classification/input.py 97.05% <100.00%> (+0.39%) ⬆️
flash/tabular/regression/data.py 97.29% <100.00%> (+0.52%) ⬆️
flash/tabular/regression/input.py 96.42% <100.00%> (+0.59%) ⬆️
flash/text/question_answering/model.py 93.19% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897e31b...750123a. Read the comment docs.

@krshrimali krshrimali marked this pull request as ready for review May 10, 2022 04:00
@ethanwharris ethanwharris added the enhancement New feature or request label May 10, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone May 10, 2022
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😃 LGTM!

@ethanwharris ethanwharris merged commit b112837 into master May 10, 2022
@ethanwharris ethanwharris deleted the tabular_c_r/from_lists branch May 10, 2022 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load tabular classifcation / regression data from lists of dicts
2 participants