Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

switch to torchmetrics #169

Merged
merged 9 commits into from
Mar 12, 2021
Merged

switch to torchmetrics #169

merged 9 commits into from
Mar 12, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 11, 2021

What does this PR do?

switch to torchmetrics

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) March 11, 2021 12:09
@Borda Borda added the enhancement New feature or request label Mar 11, 2021
@kaushikb11
Copy link
Contributor

@Borda

ERROR: Could not find a version that satisfies the requirement torchmetrics==0.2 (from lightning-flash)
ERROR: No matching distribution found for torchmetrics==0.2

@Borda
Copy link
Member Author

Borda commented Mar 11, 2021

yes, the package is not in final release yet, just RC, so will rerun tests when it is up... :]

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to see this !

@Borda Borda requested a review from edenlightning as a code owner March 12, 2021 13:49
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #169 (82b3835) into master (dbb768c) will decrease coverage by 7.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   87.39%   79.88%   -7.52%     
==========================================
  Files          49       49              
  Lines        1579     1581       +2     
==========================================
- Hits         1380     1263     -117     
- Misses        199      318     +119     
Flag Coverage Δ
unittests 79.88% <100.00%> (-7.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/classification/model.py 79.31% <100.00%> (+0.73%) ⬆️
flash/text/classification/model.py 66.66% <100.00%> (-30.31%) ⬇️
flash/text/seq2seq/summarization/metric.py 84.48% <100.00%> (-12.07%) ⬇️
flash/text/seq2seq/translation/metric.py 95.83% <100.00%> (ø)
flash/vision/classification/model.py 100.00% <100.00%> (ø)
flash/vision/embedding/image_embedder_model.py 79.66% <100.00%> (ø)
flash/text/seq2seq/core/data.py 30.13% <0.00%> (-54.80%) ⬇️
flash/text/classification/data.py 31.86% <0.00%> (-53.85%) ⬇️
flash/text/seq2seq/translation/model.py 55.55% <0.00%> (-16.67%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb768c...51006ed. Read the comment docs.

@Borda Borda disabled auto-merge March 12, 2021 16:07
@Borda Borda merged commit 1f93ce1 into master Mar 12, 2021
@Borda Borda deleted the req/metrics branch March 12, 2021 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants