Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

enforce random sampling at first call in kornia parallell transforms #351

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

edgarriba
Copy link
Contributor

@edgarriba edgarriba commented Jun 1, 2021

What does this PR do?

enables to reuse the transforms parameters for kornia transforms in different calls

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #351 (6af13d7) into master (2da2328) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   88.82%   88.82%           
=======================================
  Files          80       80           
  Lines        4143     4144    +1     
=======================================
+ Hits         3680     3681    +1     
  Misses        463      463           
Flag Coverage Δ
unittests 88.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/transforms.py 100.00% <ø> (ø)
flash/core/data/transforms.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da2328...6af13d7. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some failing tests. Is there any reason anyonme would want to do this though? It looks like reuse_params=True will make it apply the same transform every time, so you're not really getting an augmentation just a constant transform.

flash/core/data/transforms.py Outdated Show resolved Hide resolved
@edgarriba edgarriba changed the title add reuse_params in KorniaParallelTransforms enforce random sampling at first call in kornia parallell transforms Jun 1, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@pep8speaks
Copy link

pep8speaks commented Jun 1, 2021

Hello @edgarriba! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-01 14:06:51 UTC

@ethanwharris ethanwharris merged commit 55dddea into master Jun 1, 2021
@ethanwharris ethanwharris deleted the feat/kornia_reuse-params branch June 1, 2021 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants